Modeled Coverage - Phase 1 #578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jeff Grunewald <jeff.grunewald@gmail.com>
Co-authored-by: Jeff Grunewald <jeff.grunewald@gmail.com>
bbalser
reviewed
Jul 31, 2023
bbalser
reviewed
Jul 31, 2023
bbalser
reviewed
Jul 31, 2023
andymck
reviewed
Jul 31, 2023
andymck
reviewed
Aug 1, 2023
bbalser
approved these changes
Aug 2, 2023
andymck
approved these changes
Aug 3, 2023
jeffgrunewald
approved these changes
Aug 10, 2023
| @@ -13,7 +13,7 @@ use futures::{ | |||
| stream::{Stream, StreamExt, TryStreamExt}, | |||
| TryFutureExt, | |||
| }; | |||
| use h3o::LatLng; | |||
| // use h3o::LatLng; | |||
There was a problem hiding this comment.
Suggested change
| // use h3o::LatLng; |
not needed or will this come into play in phase 3?
| @@ -459,6 +465,7 @@ async fn validate_heartbeat( | |||
| if coverage.max_distance_km(latlng) > max_distance { | |||
| return Ok((cell_type, proto::HeartbeatValidity::TooFarFromCoverage)); | |||
| } | |||
| */ | |||
There was a problem hiding this comment.
you said "removed" did you mean more specifically that we should be invalidating these in phase 3 so this is only temporarily commented out or was this intended to be deleted once it successfully compiled or something?
andymck
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.