-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor speedtests handling, ensure rewards only include tests up until epoch end #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymck
commented
Jul 28, 2023
maplant
reviewed
Jul 28, 2023
maplant
reviewed
Jul 28, 2023
maplant
reviewed
Jul 28, 2023
maplant
reviewed
Jul 28, 2023
maplant
reviewed
Jul 28, 2023
maplant
reviewed
Aug 2, 2023
maplant
reviewed
Aug 8, 2023
andymck
force-pushed
the
andymck/roll-avg-refactor
branch
from
August 9, 2023 11:17
b5f767b
to
226da1d
Compare
bbalser
approved these changes
Aug 10, 2023
bbalser
approved these changes
Aug 14, 2023
andymck
force-pushed
the
andymck/roll-avg-refactor
branch
from
August 16, 2023 11:30
57f8126
to
65ac933
Compare
maplant
approved these changes
Aug 16, 2023
jeffgrunewald
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the speedtests to prevent scenario whereby the rewards can use reports from after the epoch end. To accommodate this I had to explode the speedtests reports in the DB from 1 row containing an array of up to 6 reports out into 1 row per report.
At the same time i have split the averaging code out from the speedtest module into its own module for better readability and maintainability.