Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream permission for hpr listing skfs or euis #583

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

michaeldjeffrey
Copy link
Contributor

Allows a sanity check from routing infrastructure to re-request information for a specific route without requiring reloading the entire database of routing information.

There can be times where the updating of a routes skfs or euis can be weird.
An EUI/SKF can be added and removed in an order where HPRs end up with the record, but it no longer exists in the database. Subsequent requests to remove the record from the Config Service will "succeed", but not send any updates to HPRs because no update was made to the database.

Adding HPR permission to list_skfs and get_euis allows them to do a sanity check of a single route.

Allows a sanity check from routing infrastructure to re-request
information for a specific route without requiring reloading
the entire database of routing information.
Copy link
Contributor

@jeffgrunewald jeffgrunewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me; only question: should this change apply to the get_devaddrs() request as well?

allow an hpr to retreive all parts of a route individually
@jeffgrunewald jeffgrunewald merged commit 021efe8 into main Aug 1, 2023
1 check passed
@jeffgrunewald jeffgrunewald deleted the mj/stream-request-permission-for-euis-and-skfs branch August 1, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants