verify asserted device type against wifi HB cell type #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymck
force-pushed
the
andymck/wifi-heartbeats-plus-assert-device-type-check
branch
from
e26e3f4
to
5da4cd4
Compare
andymck
force-pushed
the
andymck/wifi-heartbeats
branch
4 times, most recently
from
f45d5c8
to
32e5344
Compare
andymck
force-pushed
the
andymck/wifi-heartbeats-plus-assert-device-type-check
branch
from
5da4cd4
to
072d051
Compare
andymck
force-pushed
the
andymck/wifi-heartbeats-plus-assert-device-type-check
branch
from
072d051
to
1e54909
Compare
| pub enum GatewayResolution { | ||
| GatewayNotFound, | ||
| GatewayNotAsserted, | ||
| AssertedLocation(u64), | ||
| GatewayAsserted(GatewayMetadata), |
There was a problem hiding this comment.
does it make sense to include the entire metadata struct in the GatewayAsserted variant when it should have metadata to include the device type even if it's not asserted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.