Update locate command to support validated heartbeats and speedtest a… #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymck
reviewed
Nov 6, 2023
file_store/src/heartbeat.rs
Outdated
| pub struct ValidatedHeartbeat { | ||
| pub cbsd_id: String, | ||
| pub pub_key: PublicKeyBinary, | ||
| pub reward_multiplier: f32, |
There was a problem hiding this comment.
should we be keeping all the numbers that factor into rewards calculations be kept as integers or decimals? we've allowed a few floats but I think those have so far always been relative to things like transmit values and other RF-things
bbalser
force-pushed
the
bbalser/locate-mv-updates
branch
from
85bb26b
to
ad75cfc
Compare
andymck
approved these changes
Nov 10, 2023
They are different enough, I am not sure they should be combined. This new one is meant as the rust version of the proto, where the one in the mobile verifier is the struct representing a validated heartbeat during the validation process and has other stuff in needed for that process. For the moment, I moved these new ones into a cli module. |
jeffgrunewald
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…verages