Refactor FileSinkBuilder

[michaeldjeffrey]

FileSink.file_upload was added as an alternative FileSink.deposits.

They behave in a mutually exclusive manner, and no production code was constructing a FileSink without providing a FileUpload. (There was one test that made a FileSink without a destination channel).

This PR removes the ability to use FileSinkBuilder.deposits and the corresponding FileSink.deposits;
and requires a FileUpload when constructing a FileSinkBuilder.

[andymck]

One thing to consider here, some non oracle applications may be using the old deposits. I guess things will break should they update to latest filestore and force a refactor

[michaeldjeffrey]

One thing to consider here, some non oracle applications may be using the old deposits. I guess things will break should they update to latest filestore and force a refactor

Great point, here's something for the release notes.

---

file_sink::FileSinkBuilder API breaking change

• The method signature for FileSinkBuilder::new has been updated to include file_upload.

  let (sink, mut sink_server) = file_sink::FileSinkBuilder::new(
      FileType::MapperMsg,
      store_base_path,
+     file_upload.clone(),
      concat!(env!("CARGO_PKG_NAME"), "_mapper_msg"),
      shutdown_listener.clone(),
  )
- .file_upload(Some(file_upload.clone()))
  .roll_time(Duration::minutes(SINK_ROLL_MINS))
  .create()
  .await?;

• FileSinkBuilder::deposits method has been removed.

  let (sink, mut sink_server) = file_sink::FileSinkBuilder::new(
      FileType::MapperMsg,
      store_base_path,
+     file_upload::FileUpload { sender: file_upload_tx.clone()) },
      concat!(env!("CARGO_PKG_NAME"), "_mapper_msg"),
      shutdown_listener.clone(),
  )
-  .deposits(Some(file_upload_tx.clone()))
  .roll_time(Duration::minutes(SINK_ROLL_MINS))
  .create()
  .await?;

[michaeldjeffrey]

• https://github.com/novalabsxyz/spotmapper-ingest/blob/main/src/cli/server.rs#L44
• https://github.com/novalabsxyz/hmh-diagnostics/blob/041f935b6890c595eeccbc7cbfb49761027caa90/ingest/src/main.rs#L315
• https://github.com/novalabsxyz/subscriber-location-service/blob/2ad7c8250c0c79c0d1061ace5f1ca48fc8a85d61/mapper_verifier/src/main.rs#L81

@lthiery and @jeffgrunewald, for next time you update your file_store dep.