Fix clippy

[macpie]

It seems like this version of Rust does not like to have struct and impl in different files.

[jeffgrunewald]

instead of duplicating the MockHexBoostingClient struct definition in each of the test files, couldn't you instead centralize the impl MockHexBoostingClient new method in the tests/common module? they appear to be identical.

perhaps that also solves the problem of the struct and the impl being in different places but without the amount of duplication? not sure why those new methods were implemented multiple times but that could certainly cause issues

[macpie]

I have tried and clippy is not happy:

error: associated function `new` is never used
  --> mobile_verifier/tests/common/mod.rs:26:12
   |
25 | impl MockHexBoostingClient {
   | -------------------------- associated function in this implementation
26 |     pub fn new(boosted_hexes: Vec<BoostedHexInfo>) -> Self {
   |            ^^^
   |
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`

But new is used...

[jeffgrunewald]

I would go with that approach and just slap a #[allow(dead_code)] on the new method and be done with it. I think you're right that it's just unnecessarily confused by how the test environment is compiled. The above bandage is stupid but it works and allows us to maintain the struct and new impl in one place

[jeffgrunewald]

Why do you hate proper hygienic testing, Rust?