-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage_map
crate to provide CoverageMapBuilder
and CoverageMap
data structures
#819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maplant
changed the title
DRAFT: Add
Add May 31, 2024
coverage_map
crate to provide CoverageMapBuilder
and CoverageMap
data structurescoverage_map
crate to provide CoverageMapBuilder
and CoverageMap
data structures
When there's a single radio covering 2 hexes, both hexes should come back with rank #[test]
fn single_radio() {
let mut indoor_coverage = IndoorCellTree::default();
insert_indoor_coverage_object(
&mut indoor_coverage,
indoor_cbrs_coverage_with_loc(
"1",
Cell::from_raw(0x8c2681a3064d9ff).unwrap(),
date(2022, 2, 2),
),
);
insert_indoor_coverage_object(
&mut indoor_coverage,
indoor_cbrs_coverage_with_loc(
"1",
Cell::from_raw(0x8c2681a3064dbff).unwrap(),
date(2022, 2, 2),
),
);
let coverage = into_indoor_coverage_map(indoor_coverage, &NoBoostedHexes, Utc::now())
.collect::<Vec<_>>();
for ranked in coverage {
println!("{ranked:?}");
}
} |
Fixed and added as test |
bbalser
approved these changes
Jun 5, 2024
michaeldjeffrey
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this new crate provide?
CoverageMapBuilder
: A data structure for keeping track of the current rank of all of the radios providing coverage to a given set of hexes. This data structure does not allow you to map radios to their ranked hex coverage, but allows you to build theCoverageMap
data structure which does. Additionally, you can create a "submap" from aCoverageMapBuilder
and a collection ofCoverageObject
s, which allows for inserting ranking only those hexes which are relevant to the set ofCoverageObject
s provided.CoverageMap
: A data structure that maps hotspots to all of their ranked hex coverage.What work is left to do in this crate?
This crate is basically complete, but the following work remains:
submap
method.