Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage Point Calculator Integration with mobile-verifier #830

Merged
merged 42 commits into from
Jun 21, 2024

Commits on May 31, 2024

  1. Configuration menu
    Copy the full SHA
    c119128 View commit details
    Browse the repository at this point in the history
  2. derive Debug for nested types

    will help with the switchover
    michaeldjeffrey committed May 31, 2024
    Configuration menu
    Copy the full SHA
    2d916a5 View commit details
    Browse the repository at this point in the history
  3. CoveragePoints uses CoveragePoint2 internally

    This makes coverage points async internally. When cleanup is done there will be a single instance of CoveragePoints.
    michaeldjeffrey committed May 31, 2024
    Configuration menu
    Copy the full SHA
    17eee39 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    df04fdd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e297687 View commit details
    Browse the repository at this point in the history
  6. update with rename SubscriberThreshold -> RadioThreshold

    thresholds being met for a radio are not only about subscribers.
    michaeldjeffrey committed May 31, 2024
    Configuration menu
    Copy the full SHA
    0f136a0 View commit details
    Browse the repository at this point in the history
  7. filter for boosted hexes during report generation

    It's the responsibility of the report to only include hexes with active boost values
    michaeldjeffrey committed May 31, 2024
    Configuration menu
    Copy the full SHA
    3f554d3 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Configuration menu
    Copy the full SHA
    8af4dfc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc87785 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Start adding coverage-map in mobile-verifier

    Keep disctinction between SignalLevel in coverage and coverage-map, this way coverage-map doesn't need to bring in sqlx as a dependency
    michaeldjeffrey committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9a78c72 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Configuration menu
    Copy the full SHA
    f80434a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e18db32 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6ad9044 View commit details
    Browse the repository at this point in the history
  4. Skip a radio for rewards if it cannot be constructed properly

    rewards should never fail. but we can skip a radio and have an alert that says something went wrong.
    michaeldjeffrey committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    2fb1984 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Configuration menu
    Copy the full SHA
    fca62dd View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2024

  1. Configuration menu
    Copy the full SHA
    fec7b71 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ab77338 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    75ef0d4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    830b89b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2bdbc86 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Configuration menu
    Copy the full SHA
    055d4d4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f3afac9 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Configuration menu
    Copy the full SHA
    e025f68 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Configuration menu
    Copy the full SHA
    6114221 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. clean up trust_score construction and long types

    Move zipping trust scores with their distances to heartbeatreward.
    Leave
    
    I put the use statements above where they are in the function because the names of the types kind of overlap with the names used in the mobile verifier, and I wanted to make it extra clear to anyone reading, this function is transforming those values into calculator types.
    michaeldjeffrey committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    1ad133a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a7d6422 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d2112f4 View commit details
    Browse the repository at this point in the history
  4. remove need for cloning radio_info

    we can clone the speed_tests and trust_scores as they enter the calculator, but everything else can work with a reference for much longer.
    michaeldjeffrey committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    17b8009 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    88d7a3e View commit details
    Browse the repository at this point in the history
  6. rename coverage points constructor

    The constructor no longer tries to calculate points, it collects information about radios and coverage. All the pointing happens in into_rewards.
    michaeldjeffrey committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    811bbe2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3b28098 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    751cedc View commit details
    Browse the repository at this point in the history
  9. Rename CoveragePoints -> CoverageShares

    This matches with the other reward structs `MapperShares`, `ServiceProviderShares`. 
    
    And reflects more that we're talking about `reward_shares`, where `coverage_points` is starting to mean points provided towards shares relating only to coverage (excluding backhaul (speedtests)).
    michaeldjeffrey committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    e7449e1 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    8ea92d4 View commit details
    Browse the repository at this point in the history
  11. remove location trust score calculation

    This all lives in the coverage-point-calculator now
    michaeldjeffrey committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    f7cc0a5 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4c5fa59 View commit details
    Browse the repository at this point in the history
  13. construct coverage map inside block scope

    We can insert coverage objects directly after iterating over them, radio_info only needs to know if the radio `is_indoor`. Moving that binding to the top helps hint that it's set by something in the block and returned.
    
    And we don't need to carry around covered_hexes for any longer than necessary.
    michaeldjeffrey committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    c93159b View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    eb1b869 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Configuration menu
    Copy the full SHA
    bf9ee9d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    360981d View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Configuration menu
    Copy the full SHA
    7f0dfae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    07f864c View commit details
    Browse the repository at this point in the history