Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verification Mapping #839

Merged
merged 44 commits into from
Aug 13, 2024
Merged

Verification Mapping #839

merged 44 commits into from
Aug 13, 2024

Conversation

macpie
Copy link
Member

@macpie macpie commented Jul 9, 2024

No description provided.

@macpie macpie changed the title Add verification_mapping proto Verification Mapping Jul 9, 2024
@macpie macpie force-pushed the macpie/verification_mapping branch from a46ccc0 to 7953016 Compare July 11, 2024 22:20
andymck
andymck reviewed Jul 18, 2024
View reviewed changes
file_store/src/verified_mapping_event.rs Outdated Show resolved Hide resolved
ingest/src/server_mobile.rs Show resolved Hide resolved
mobile_verifier/src/reward_shares.rs Outdated Show resolved Hide resolved
file_store/src/verified_mapping_event.rs Outdated Show resolved Hide resolved
ingest/src/server_mobile.rs Outdated Show resolved Hide resolved
mobile_verifier/src/reward_shares.rs Outdated Show resolved Hide resolved
andymck
andymck reviewed Jul 26, 2024
View reviewed changes
file_store/src/file_info.rs Outdated Show resolved Hide resolved
file_store/src/verified_subscriber_mapping_event.rs Outdated Show resolved Hide resolved
mobile_verifier/src/reward_shares.rs Show resolved Hide resolved
@macpie macpie force-pushed the macpie/verification_mapping branch 2 times, most recently from b9293e7 to 9998592 Compare July 29, 2024 21:21
@macpie macpie marked this pull request as ready for review July 30, 2024 19:24
andymck
andymck reviewed Aug 1, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
ingest/tests/common/mod.rs Outdated Show resolved Hide resolved
mobile_verifier/src/reward_shares.rs Show resolved Hide resolved
andymck
andymck reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@andymck andymck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good and is close, just a couple of nits. One thing to note is we should not merge this until the appropriate time as it changes existing reward outputs

Cargo.toml Outdated Show resolved Hide resolved
mobile_verifier/src/reward_shares.rs Show resolved Hide resolved
@andymck andymck mentioned this pull request Aug 2, 2024
Closed
@macpie macpie force-pushed the macpie/verification_mapping branch from 6f21b07 to 4f8b0d2 Compare August 2, 2024 19:03
@bbalser
Copy link
Contributor

bbalser commented Aug 7, 2024

Needs to validate the carrier mapping key and subscriber id and write out a report to the output bucket with the report and the status of the report. Look at subscriber location as an example.

oracles/mobile_verifier/src/subscriber_location.rs

Line 123 in 341b6e1

async fn process_file(

macpie and others added 21 commits August 13, 2024 14:16
@macpie @andymck @jeffgrunewald
Update mobile_verifier/src/reward_shares.rs
68dd915 
Co-authored-by: andymck <andrewb.mckenzie@gmail.com>
@macpie @jeffgrunewald
Fix var name
8771358
@macpie @jeffgrunewald
Add verification_mapping_amount to subscriber_reward
adbd484
@macpie @jeffgrunewald
Use git+https://github.com/helium/proto?branch=macpie%2Fverification_…
303b52f 
…mapping#helium-proto@0.1.0
@macpie @jeffgrunewald
Do not acc rewards
2dfaf8e
@macpie @jeffgrunewald
Improve tests
45afaf6
@macpie @jeffgrunewald
Add timeout to test client
a0a7743
@macpie @jeffgrunewald
The moogey commit
b0384a1
@macpie @jeffgrunewald
Cleanup (txh moogey)
860bf33
@macpie @jeffgrunewald
Fix tests
6ad41c9
@macpie @jeffgrunewald
Add some println
a5cb80f
@macpie @jeffgrunewald
Fix timestamp issue
e82fd93
@macpie @jeffgrunewald
Remove unused fn
36459f4
@macpie @jeffgrunewald
Rename for consistency
ae4e192
@macpie @jeffgrunewald
Add verified ingest report and rename
8a8c653
@macpie @jeffgrunewald
Fix proto
4234177
@macpie @jeffgrunewald
Clear older events
83bee39
@macpie @jeffgrunewald
Update table name and use reward_period.start
2dc6162
@andymck @jeffgrunewald
requirements originating from verification mapping verifier
8f02efa
@jeffgrunewald
revert proto/beacon to master branch
d91967b
@jeffgrunewald
fix proto master branch ref
3c6b24a
@jeffgrunewald jeffgrunewald merged commit 8dc6c15 into main Aug 13, 2024
17 checks passed
@jeffgrunewald jeffgrunewald deleted the macpie/verification_mapping branch August 13, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andymck andymck andymck left review comments

@michaeldjeffrey michaeldjeffrey michaeldjeffrey left review comments

@bbalser bbalser bbalser approved these changes

@jeffgrunewald jeffgrunewald jeffgrunewald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@macpie @bbalser @andymck @michaeldjeffrey @jeffgrunewald