-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Solana workspace to use helium-lib
#850
Open
michaeldjeffrey
wants to merge
13
commits into
main
Choose a base branch
from
mj/solana-using-helium-lib
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes the need for a keypair conversion
michaeldjeffrey
force-pushed
the
mj/solana-using-helium-lib
branch
from
October 22, 2024 21:58
8e5b5d8
to
4a0a0b0
Compare
helium-lib is trying to avoid any type of file io
michaeldjeffrey
force-pushed
the
mj/solana-using-helium-lib
branch
from
October 23, 2024 16:33
24ed3ad
to
a62bc2f
Compare
Way down deep we had 2 versions of anchor-lang being loaded at the same time. And they were both definining conflicting entrypoints. oracles -> helium-anchor-gen -> anchor-lang@0.30 oracles -> helium-lib -> spl-account-compression -> anchor-lang@0.29 helium-anchor-gen was backed down to need >=0.28 and that has fixed the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion helium-lib PR helium/helium-wallet-rs#401
Still in progress of moving the
solana
workspace to usehelium-lib
when it can.helium-lib
.price
workspace.helium-lib