Fix rare case where the file info poller will re-process old files #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbalser
reviewed
Aug 13, 2024
bbalser
approved these changes
Aug 19, 2024
|
This PR still exhibits a bug that could occur when the cleaner runs 12 hours after boot. Closing in favor a solution to only modifies the cleaning algorithm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a case where on devnet, the reward indexer would re-process old files after cleaning out the files processed table. This is due to the offset being further back in time than the oldest file in the files processed table due to a burst of files. This PR fixes that by checking for a full files processed table, and if it is full limiting the offset to be at most the oldest timestamp in the table.