Implementation of HIP-131 #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymck
approved these changes
Aug 28, 2024
| @@ -76,7 +77,9 @@ pub(crate) fn clean_covered_hexes( | |||
|
|
|||
| // hip-103: if a hex is boosted by a service provider >=1x, the oracle | |||
| // multiplier will automatically be 1x, regardless of boosted_hex_status. | |||
| let assignment_multiplier = if ranked.boosted.is_some() { | |||
There was a problem hiding this comment.
above comment needs an update
|
If HIP-131 was more than a stop-gap measure for another HIP, I would like to see it integrated into the calculator as more than a boolean. But it does introduce the concept of a boosted hex restriction applying to oracle boosting, whereas it was only service provider boosting before. It could be a nice idea to extend |
bbalser
force-pushed
the
bbalser/hip-125-extended
branch
from
73a0c61
to
7cb1429
Compare
Why pass in information from a source that we're going to be using gratuitously within the same function. Did I spell that right?
bbalser
force-pushed
the
bbalser/hip-125-extended
branch
from
fb5fa7f
to
1a0e51b
Compare
michaeldjeffrey
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/helium/HIP/blob/main/0131-bridging-gap-between-verification-mappers-and-anti-gaming-measures.md
New Ban_type(PoC) is added and is radio is is banned with type PoC then all assignment_multipliers for it are set to 0.0.