Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix roll_time and auto_commit settings for FileSink #859

Merged
merged 3 commits into from
Aug 30, 2024

Commits on Aug 29, 2024

  1. Add FileSinkCommitStrategy

    This hopefully clears up, at least for the use of the FileSinkWriteExt
    trait the relationship between `auto_commit` and `roll_time`. There is
    no default implementaion for this option, as all options have
    implications that should be considered.
    michaeldjeffrey committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    0faed88 View commit details
    Browse the repository at this point in the history
  2. Correct FileSink auto_commit and roll_time usage in Oracles

    The PR that updated FileSink to use the Ext trait had an incorrect
    understanding of the relationship between `roll_time` and `auto_commit`.
    
    That understanding has since been corrected and codified in the
    `FileSinkCommitStrategy` enum.
    
    For this commit, https://github.com/helium/oracles/pull/849/files was
    combed through to get all correct settings for FileSinks before they
    were transitioned to use FileSinkWriteExt::file_sink().
    michaeldjeffrey committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    07ee3d4 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Change so auto_commit and roll_time are separated (#860)

    * Change so auto_commit and roll_time are separated
    
    * Create FileSinkRollTime enum
    bbalser authored Aug 30, 2024
    Configuration menu
    Copy the full SHA
    dfa99d4 View commit details
    Browse the repository at this point in the history