[Mobile Config] Add device_types filter to stream_gateways_info #880
+369
−224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurotych
changed the title
kurotych
force-pushed
the
gateway_info_stream_filtered
branch
from
a419d30
to
ef9d21a
Compare
mobile_config/src/gateway_service.rs
Outdated
| tracing::debug!("fetching all gateways' info"); | ||
| tracing::debug!( | ||
| "fetching all gateways' info. Device types: {:?} ", | ||
| request.device_types |
There was a problem hiding this comment.
should this debug statement come after the map below? it would debug to a vec of i32s before that conversion, no?
andymck
reviewed
Oct 25, 2024
| .bind( | ||
| device_types | ||
| .iter() | ||
| .map(|v| format!("\"{}\"", v)) |
There was a problem hiding this comment.
I assume the escaping here is required ? A note to explain why would be useful for future readers, especially given the table schema is managed outside of the oracles
There was a problem hiding this comment.
The device_types field has a jsonb type but is being used as a string, which forces us to add quotes.
Column in "meta" database:
(Added comment to code)
There was a problem hiding this comment.
not sure it is a better idea but you can query the field normally like this
WHERE mhi.device_type #>> '{}' = 'wifiDataOnly'
andymck
approved these changes
Oct 25, 2024
kurotych
force-pushed
the
gateway_info_stream_filtered
branch
from
d7cd30a
to
426a489
Compare
jeffgrunewald
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.