create mapper service #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lthiery
force-pushed
the
lthiery/mapper-service
branch
from
e5fa802
to
e5edfde
Compare
JayKickliter
reviewed
Jun 1, 2023
JayKickliter
reviewed
Jun 1, 2023
There was a problem hiding this comment.
what's the intention of the mapper service and where will the grpc server that upload rpc be running? if the messages are intended to be ingested into the iot and/or mobile oracle rewardable coverage pipelines then this service definition should probably be folded into either the poc_mobile or poc_lora services and the upload rpc renamed to submit_mapper or similar to be consistent with the other PoC data submission messages per
proto/src/service/poc_lora.proto
Line 225 in f1208e2
proto/src/service/poc_mobile.proto
Line 99 in f1208e2
if these are meant for something else then disregard
lthiery
force-pushed
the
lthiery/mapper-service
branch
from
34b7be5
to
d4f3457
Compare
lthiery
force-pushed
the
lthiery/mapper-service
branch
3 times, most recently
from
b2a395d
to
c13e7c6
Compare
lthiery
force-pushed
the
lthiery/mapper-service
branch
from
ee531f6
to
2fdf644
Compare
lthiery
force-pushed
the
lthiery/mapper-service
branch
from
2fdf644
to
29d7297
Compare
devilish66694
approved these changes
Jun 25, 2024
|
Closed due to lack of activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.