manage fcnt #1003
Merged
manage fcnt #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That would refuse all future copies of this packet because they exceeded the multi-buy. We want the rest of the already purchased packets to come through okay.
don't re-check here, the packet was bought, let's use it
This already happens deeper in this call graph when the packet is accepted and used
the max 32bit frame count is somewhere in the 4billions. the highest frame count for a device in use here is ~1,800,000. 136 years has about 4billion seconds.
The device_worker will be provided with the verified fcnt rather than the expected fcnt when handling a packet.
michaeldjeffrey
force-pushed
the
mj/manage-fcnt
branch
from
385ae57
to
63dd02c
Compare
michaeldjeffrey
commented
Sep 25, 2023
| @@ -1185,80 +1182,66 @@ get_and_sort_devices(DevAddr, PubKeyBin) -> | |||
| get_device_by_mic(_MIC, _Payload, []) -> | |||
| undefined; | |||
| get_device_by_mic(ExpectedMIC, Payload, [Device | Devices]) -> | |||
| ExpectedFCnt = expected_fcnt(Device, Payload), | |||
There was a problem hiding this comment.
Don't guess at what the fcnt should be.
Iterate through the higher frame bits and determine for certain what the frame count is.
Then we can pass that fcnt through to the device worker and know it's verified.
macpie
reviewed
Sep 26, 2023
macpie
reviewed
Sep 26, 2023
A verified frame count is being provided here rather than a speculative frame count.
macpie
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.