add static page to user model by CLJoker · Pull Request #93 · hellovietnam93/Ruby_k59

CLJoker · 2017-03-21T16:24:48Z

sign up

sign up + deleted folder static page

hellovietnam93 · 2017-03-21T16:37:09Z

Gemfile

sử dụng nháy kép thay cho nháy đơn

hellovietnam93 · 2017-03-21T16:37:14Z

Gemfile

xóa tất cả comment trong file này

hellovietnam93 · 2017-03-21T16:37:22Z

app/assets/javascripts/static_pages.coffee

file này k dùng thì xóa đi nhé

hellovietnam93 · 2017-03-21T16:37:27Z

app/assets/javascripts/users.coffee

file này k dùng thì xóa đi

hellovietnam93 · 2017-03-21T16:37:35Z

app/assets/stylesheets/custom.scss

1 dấu csh sau dấu : thôi nhé

hellovietnam93 · 2017-03-21T16:40:19Z

app/views/static_pages/help.html.erb

cách ra trước và sau %

hellovietnam93 · 2017-03-21T16:40:35Z

app/views/users/new.html.erb

xóa () + sử dụng nháy kép

hellovietnam93 · 2017-03-21T16:40:41Z

app/views/users/new.html.erb

hellovietnam93 · 2017-03-21T16:41:16Z

app/views/users/show.html.erb

hellovietnam93 · 2017-03-21T16:41:31Z

config/routes.rb

xóa () 1 dấu cách để ngăn thôi nhé

hellovietnam93 · 2017-03-22T01:05:41Z

app/controllers/users_controller.rb

ident, lùi so với dòng bên trên thôi

hellovietnam93 · 2017-03-22T01:05:58Z

app/controllers/users_controller.rb

params.require(:user).permit :name ....
em k test code à?

hellovietnam93 · 2017-03-22T01:06:13Z

app/views/layouts/application.html.erb

hellovietnam93 · 2017-03-22T01:06:17Z

app/views/layouts/application.html.erb

hellovietnam93 · 2017-03-22T01:06:22Z

app/views/shared/_error_messages.html.erb

hellovietnam93 · 2017-03-22T01:06:33Z

app/views/static_pages/about.html.erb

cái j đya?

hellovietnam93 · 2017-03-22T01:06:39Z

app/views/static_pages/help.html.erb

hellovietnam93 · 2017-03-22T01:06:50Z

app/views/static_pages/home.html.erb

sư dụng ""

hungnh103 · 2017-03-22T01:50:06Z

Gemfile

-# Use Capistrano for deployment
-# gem 'capistrano-rails', group: :development
+gem "bcrypt", "3.1.7"
+


e xóa dòng này và các dòng 13, 15, 17, 19, 21, 23, 25, 27 nhé

hungnh103 · 2017-03-22T01:55:52Z

app/helpers/users_helper.rb

remove ( )

hungnh103 · 2017-03-22T01:55:59Z

app/helpers/users_helper.rb

remove ()

hungnh103 · 2017-03-22T01:57:05Z

app/views/layouts/_header.html.erb

thiếu khoảng trắng
viết đúng convention thì như này em nhé:
<%= link_to "Sample App", "#", id: "logo" %>

hungnh103 · 2017-03-22T01:57:32Z

app/views/layouts/_shim.html.erb

hungnh103 · 2017-03-22T02:01:12Z

config/routes.rb

e xóa dòng này và các dòng 5, 7, 9, 11 nhé

hungnh103 · 2017-03-22T02:01:40Z

config/routes.rb

remove comment

hungnh103 · 2017-03-22T02:02:53Z

static_page/db/seeds.rb

 #   movies = Movie.create([{ name: 'Star Wars' }, { name: 'Lord of the Rings' }])
 #   Character.create(name: 'Luke', movie: movies.first)
+10.times do |n|
+  User.create name: "User #{n}", email: "email-#{n}@gmail.com"


e xóa hết comment trong file này và sửa lại cách viết dòng này nhé:
User.create! name: "User #{n}", email: "email-#{n}@gmail.com"

hungnh103 · 2017-03-22T02:03:06Z

test/controllers/static_pages_controller_test.rb

use double quote " " in Rails

hungnh103 · 2017-03-22T02:03:16Z

test/controllers/users_controller_test.rb

use double quote " " in Rails

hellovietnam93 · 2017-03-22T09:04:20Z

app/views/static_pages/help.html.erb

ident, sao lại lùi vòa thé?

hellovietnam93 · 2017-03-22T09:32:41Z

app/controllers/users_controller.rb

params.require(:user)

sign up sign up + deleted folder static page readd fix fix second time fix time 3 fix time 4 fix time 5 fix 6 time

hungnh103 · 2017-03-22T16:04:29Z

Gemfile

 end

+gem "rails", "~> 5.0.2"



xóa dòng này em nhé

hungnh103 · 2017-03-22T16:04:35Z

Gemfile

-# See https://github.com/rails/execjs#readme for more supported runtimes
-# gem 'therubyracer', platforms: :ruby
+gem "bcrypt", "3.1.7"



xóa dòng nhé

hungnh103 · 2017-03-22T16:06:07Z

app/views/layouts/_footer.html.erb

+  <nav>
+    <ul>
+      <li><%= link_to "About", static_pages_about_path %></li>
+      <li><%= link_to "Contact", '#' %></li>


use double quote " " in Rails

hungnh103 · 2017-03-22T16:07:16Z

app/views/static_pages/home.html.erb

@@ -0,0 +1,11 @@
+<%provide :title, "Home"%>


thiếu khoảng trắng

hungnh103 · 2017-03-22T16:07:33Z

app/views/static_pages/home.html.erb

+    This is the home page for the <a href="http://www.railstutorial.org/">
+      Ruby on Rails Tutorial</a> sample application.
+  </h2>
+  <%= link_to "Sign up now!", "#", class: "btn btn-lg btn-primary"%>


thiếu khoảng trắng

hungnh103 · 2017-03-22T16:09:40Z

static_page/db/seeds.rb

-#   movies = Movie.create([{ name: 'Star Wars' }, { name: 'Lord of the Rings' }])
-#   Character.create(name: 'Luke', movie: movies.first)
+10.times do |n|
+  User.create name: "User #{n}", email: "email-#{n}@gmail.com"


e thêm dấu chấm than ! ngay sau create nhé:

User.create! name: "User #{n}", email: "email-#{n}@gmail.com"

CLJoker force-pushed the sugoi_page_03 branch from 4ea337c to f0c3d90 Compare March 21, 2017 16:35

hellovietnam93 reviewed Mar 21, 2017

View reviewed changes

CLJoker force-pushed the sugoi_page_03 branch from f0c3d90 to d6cbe07 Compare March 21, 2017 17:11

hellovietnam93 reviewed Mar 22, 2017

View reviewed changes

hungnh103 reviewed Mar 22, 2017

View reviewed changes

CLJoker force-pushed the sugoi_page_03 branch from d6cbe07 to bc3d771 Compare March 22, 2017 08:59

hellovietnam93 reviewed Mar 22, 2017

View reviewed changes

app/views/static_pages/help.html.erb Outdated

Copy link

Owner

hellovietnam93 Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ident, sao lại lùi vòa thé?

CLJoker force-pushed the sugoi_page_03 branch from bc3d771 to cfda8ef Compare March 22, 2017 09:30

hellovietnam93 reviewed Mar 22, 2017

View reviewed changes

app/controllers/users_controller.rb Outdated

Copy link

Owner

hellovietnam93 Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

params.require(:user)

CLJoker force-pushed the sugoi_page_03 branch from cfda8ef to b18f9b5 Compare March 22, 2017 09:40

add static page to user model

a19d737

sign up sign up + deleted folder static page readd fix fix second time fix time 3 fix time 4 fix time 5 fix 6 time

CLJoker force-pushed the sugoi_page_03 branch from b18f9b5 to a19d737 Compare March 22, 2017 10:46

hungnh103 reviewed Mar 22, 2017

View reviewed changes

Conversation

CLJoker commented Mar 21, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone