Added screen reader texts to aria-label instead of having them in hid…

…den span-tags
helsenorge · Nov 15, 2023 · b8e5125 · b8e5125
1 parent 8199060
commit b8e5125
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/CHANGES b/CHANGES
@@ -1,3 +1,9 @@
+## 13.2.1
+
+----
+
+- Added screen reader texts to aria-label instead of having them in hidden span-tags
+
 ## 13.2.0
 
 ----

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@helsenorge/refero",
-  "version": "13.2.0",
+  "version": "13.2.1",
   "engines": {
     "node": "^18.0.0",
     "npm": ">=9.0.0"

diff --git a/src/util/index.ts b/src/util/index.ts
@@ -184,24 +184,23 @@ function getMarkdownValue(
   questionnaire?: Questionnaire | null,
   srLinkText?: string
 ): string {
-  const srLinkTextSpan = `<span style="position: absolute !important; height: 1px; width: 1px; overflow: hidden; clip: rect(1px, 1px, 1px, 1px);">${
-    srLinkText ? srLinkText : 'The link opens in a new tab'
-  }</span>`;
   const itemValue = getHyperlinkExtensionValue(item);
   const questionnaireValue = questionnaire ? getHyperlinkExtensionValue(questionnaire) : undefined;
 
   const renderer = new marked.Renderer();
   renderer.link = (href: string, title: string, text: string): string => {
     const urlString = `<a href=${href} ${
       title ? `title=${title}` : ''
-    } target="_blank" rel="noopener noreferrer" class="external">${text}${srLinkTextSpan}</a>`;
+    } target="_blank" rel="noopener noreferrer" class="external" aria-label=${
+      openNewIfAbsolute(href) === '_blank' ? srLinkText : ''
+    }>${text}</a>`;
     return urlString;
   };
   const rendererSameWindow = new marked.Renderer();
   rendererSameWindow.link = (href: string, title: string, text: string): string => {
     const urlString = `<a href=${href} ${title ? `title=${title}` : ''} target="${openNewIfAbsolute(
       href
-    )}" rel="noopener noreferrer">${text}${openNewIfAbsolute(href) === '_blank' ? srLinkTextSpan : ''}</a>`;
+    )}" rel="noopener noreferrer" aria-label=${openNewIfAbsolute(href) === '_blank' ? srLinkText : ''}>${text}</a>`;
     return urlString;
   };