fix: Validate max file size for attachments #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AG-83
reviewed
Jan 24, 2024
| @@ -118,7 +123,7 @@ function getErrorMessage( | |||
| if (!mimeTypeIsValid(file, validFileTypes)) { | |||
| return resources.validationFileType; | |||
| } else if (!sizeIsValid(file, maxFileSize)) { | |||
| return resources.validationFileMax; | |||
| return resources.validationFileMax.replace('25', (maxFileSize / 1024 / 1024).toString()); | |||
There was a problem hiding this comment.
Er ikke helt sikker at det er lurt at gjøre det hit. Er det ikke HN-Skjema sender i riktig format til refero. Kanskje det trenger ikke gjøre noe endring i feilmeldingen
AG-83
reviewed
Jan 24, 2024
| @@ -118,7 +123,7 @@ function getErrorMessage( | |||
| if (!mimeTypeIsValid(file, validFileTypes)) { | |||
| return resources.validationFileType; | |||
| } else if (!sizeIsValid(file, maxFileSize)) { | |||
| return resources.validationFileMax; | |||
| return resources.validationFileMax.replace('25', (maxFileSize / 1024 / 1024).toString()); | |||
There was a problem hiding this comment.
Vi har denne i HN-Skjema
skjemaResources.validationFileMax = skjemaResources.validationFileMax.replace(
'{0}',
DEFAULT_MAX_ATTACHMENT_FILE_SIZE_HN_SKJEMA_MB.toString()
);
| }); | ||
| const question: QuestionnaireItem = { | ||
| linkId: '4c71df6e-d743-46ba-d81f-f62777ffddb4', | ||
| type: 'attachment', |
There was a problem hiding this comment.
Det er ikke veldig viktig men man kan bruke
import itemType from '../constants/itemType';
type: itemType.ATTATCHMENT
|
Duplicate of new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses questionaire item to set the max file size to validate with Dropzone.
Default is 4MB