feature/Ny modul Modal CU 865cn09xb #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
annalinneajohansson
commented
Jul 3, 2023
annalinneajohansson
commented
- (add) ACF fields for module Modal
- (add) New module "Modal"
|
Task linked: CU-865cn09xb Ny modul: Modal |
…nt pages (add) Set mod-modal-content to not be publically queryable (ie not have their own singular pages)
…false to register_post_type
…content" since modules posttypes prefixes with mod-
…r the current post type in "enabled-post-types"
…tions for the current post type in "enabled-post-types"" This reverts commit 2ca58f4. Will fix in separate task.
sebastianthulin
requested changes
Jul 7, 2023
| * @param object $editorContext The editor context. | ||
| * @return array The updated allowed block types. | ||
| */ | ||
| public function disallowBlockType($allowedBlockTypes, $editorContext) |
There was a problem hiding this comment.
Can be replaced with this option on module creation.
https://github.com/helsingborg-stad/Modularity/blob/3.0/develop/source/php/Module.php#L105
There was a problem hiding this comment.
I'm not following your thought here; can you please explain? The module is meant to be available as a block, but not on the modal-content post type. I'm not finding any way to detect the post type currently being edited whilst registering the module.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.