fix: do not display placeholder in full variant. Do not show error wh…

…en image is missng, show placeholder.
helsingborg-stad · Oct 11, 2024 · 5b5a0ab · 5b5a0ab
1 parent c0d37db
commit 5b5a0ab
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/acf-fields/json/card.json b/acf-fields/json/card.json
@@ -8,7 +8,7 @@
             "name": "image",
             "type": "focuspoint",
             "instructions": "",
-            "required": 1,
+            "required": 0,
             "conditional_logic": 0,
             "wrapper": {
                 "width": "",
@@ -272,4 +272,4 @@
     "acfe_meta": "",
     "acfe_note": ""
 }]
-
+
diff --git a/acf-fields/php/card.php b/acf-fields/php/card.php
@@ -1,7 +1,9 @@
 <?php 
-
-if (function_exists('acf_add_local_field_group')) {
-    acf_add_local_field_group(array(
+
+
+if (function_exists('acf_add_local_field_group')) {
+
+    acf_add_local_field_group(array(
     'key' => 'group_63ff1e1238bd3',
     'title' => __('Card Section Settings', 'modularity-sections'),
     'fields' => array(
@@ -11,7 +13,7 @@
             'name' => 'image',
             'type' => 'focuspoint',
             'instructions' => '',
-            'required' => 1,
+            'required' => 0,
             'conditional_logic' => 0,
             'wrapper' => array(
                 'width' => '',
@@ -275,4 +277,5 @@
     'acfe_meta' => '',
     'acfe_note' => '',
 ));
-}
+
+}
diff --git a/source/php/Module/Card/views/card.blade.php b/source/php/Module/Card/views/card.blade.php
@@ -11,7 +11,8 @@
     'paddingBottom' => $spacing_bottom,
     'stretch' => !is_admin() && isset($blockData) ? (bool) $blockData['align'] == 'full' : $stretch,
     'context' => ['sectionsCard', 'sections', 'sections.card', 'module.sections.card'],
-    'buttons' => !empty($buttons) ? $buttons : []
+    'buttons' => !empty($buttons) ? $buttons : [],
+    'hasPlaceholder' => true,
 ])
     @if (!empty($submodules) && is_array($submodules))
         {!! $submoduleRendered !!}

diff --git a/source/php/Module/Full/views/full.blade.php b/source/php/Module/Full/views/full.blade.php
@@ -12,6 +12,7 @@
     'paddingTop'    => $spacing_top,
     'paddingBottom' => $spacing_bottom,
     'stretch'       => !is_admin() && isset($blockData) ? (bool) $blockData['align'] == 'full' : $stretch,
+    'hasPlaceholder' => false,
     'context'       => ['sectionsFull', 'sections', 'sections.full', 'module.sections.full']
 ])
     @if (!empty($submodules) && is_array($submodules))