-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve float placement in Starter section #442
Improve float placement in Starter section #442
Conversation
ramink
commented
Jan 28, 2025
- Move flow chart to top of Making a Starter Section
- Move Microbe War figure to paragraph after "epic battle"
- Move flow chart to top of Making a Starter Section - Move Microbe War figure to paragraph after "epic battle"
This is a continuation of the work in another merge request that was closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not seeing a ref in the text to microbacterialwar, but maybe I missed it. If there isn’t any it should be added.
otherwise fine with me.
There wasn't one there before, so I've added one in what seemed like the appropriate spot. Please review the change. |
Not surprised there wasn’t any :). Thanks but needs more text , see Figure~\ref bla bla Best, C |
And add a centering while at it for the figure… won’t change anything as it is full width but still better. |
Done. Please review. I used an example from section 7 as a template for capitalisation (figure vs Figure). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Figure is capitalized… see
I would autour that Flowchart above shall also be Capitalized while at it.
Done. But I'm not too happy about the change to Figure. What do you think about changing the text to: "It is in fact so easy that it can be summarized in a simple diagram (see Flowchart 3.1)" |
Congrats you made a bug much more apparent... I had not noticed before: #443 |
Thanks for the great improvements! |