Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve float placement in Starter section #442

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

ramink
Copy link
Contributor

@ramink ramink commented Jan 28, 2025

  • Move flow chart to top of Making a Starter Section
  • Move Microbe War figure to paragraph after "epic battle"

- Move flow chart to top of Making a Starter Section
- Move Microbe War figure to paragraph after "epic battle"
@ramink
Copy link
Contributor Author

ramink commented Jan 28, 2025

This is a continuation of the work in another merge request that was closed.

Copy link
Collaborator

@cedounet cedounet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not seeing a ref in the text to microbacterialwar, but maybe I missed it. If there isn’t any it should be added.

otherwise fine with me.

@ramink
Copy link
Contributor Author

ramink commented Jan 28, 2025

There wasn't one there before, so I've added one in what seemed like the appropriate spot. Please review the change.

@cedounet
Copy link
Collaborator

Not surprised there wasn’t any :).

Thanks but needs more text , see Figure~\ref bla bla

Best,

C

@cedounet
Copy link
Collaborator

And add a centering while at it for the figure… won’t change anything as it is full width but still better.

@ramink
Copy link
Contributor Author

ramink commented Jan 28, 2025

Done. Please review. I used an example from section 7 as a template for capitalisation (figure vs Figure).

Copy link
Collaborator

@cedounet cedounet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figure is capitalized… see

https://writing.stackexchange.com/questions/5482/referencing-figure-in-text-capitalize-the-word-figure-or-not-why

I would autour that Flowchart above shall also be Capitalized while at it.

@ramink
Copy link
Contributor Author

ramink commented Jan 28, 2025

Done. But I'm not too happy about the change to Figure. What do you think about changing the text to:

"It is in fact so easy that it can be summarized in a simple diagram (see Flowchart 3.1)"

@cedounet
Copy link
Collaborator

Congrats you made a bug much more apparent... I had not noticed before: #443

@cedounet cedounet merged commit 9e70d91 into hendricius:main Jan 29, 2025
1 check passed
@ramink ramink deleted the issue394_diagram_placement_v2 branch January 29, 2025 13:51
@hendricius
Copy link
Owner

Thanks for the great improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants