Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No implementation for the new Fabric Renderer? #618

Closed
FelixBaum opened this issue Feb 25, 2023 · 7 comments
Closed

No implementation for the new Fabric Renderer? #618

FelixBaum opened this issue Feb 25, 2023 · 7 comments
Labels

Comments

@FelixBaum
Copy link

FelixBaum commented Feb 25, 2023

I created a new react-native app with the new architecture and the Fabric renderer enabled.
After installing this module and adding it to a screen, I get a red space with the prompt: Unimplemented component: <RNDatePicker>.

Is a implementation for the new architecture planned? If not, can someone explain, what it would take to convert it for the new arch?

Thank you for the great date picker! Would love to use this one in my new app 🙏

@henninghall
Copy link
Owner

You are right, the new architecture is unfortunately not supported yet. I’ve looked at it briefly but haven’t been able to get the time in. I estimate it will take 10-40 hours to complete. If you want to help out with converting either the android or iOS part, or sponsoring the work it would be very appreciated, just let me know 🙏

@zhenguet
Copy link

zhenguet commented Apr 3, 2023

@henninghall I hope you will complete it as soon as possible. have a nice day

@efstathiosntonas
Copy link

@henninghall Hi, are there any updates on this one? Thanks!

@annguyen-iosdev
Copy link

Hi guys, following this update. Thanks.

@henninghall
Copy link
Owner

Hi guys, here is an update!

The work on this has been started. You can follow the progress here: #678

Currently the iOS inline picker is migrated. If you're are using the inline picker in your project, I would appreciate help with testing it out. Install it by yarn add react-native-date-picker@alpha etc. it will only compile with the new architecture enabled at the moment. Please let me know how it worked for you by adding a comment in this thread, thanks!

@henninghall henninghall pinned this issue Aug 10, 2023
@henninghall
Copy link
Owner

The iOS modal is now migrated as well

@henninghall
Copy link
Owner

The work on supporting the new architecture is completed! It is released in v4.3.0. Thanks for Nordic Brain Tech for partly sponsoring the migration.

@henninghall henninghall unpinned this issue Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants