Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React Native's new architecture #678

Merged
merged 72 commits into from
Sep 10, 2023
Merged

Support React Native's new architecture #678

merged 72 commits into from
Sep 10, 2023

Conversation

henninghall
Copy link
Owner

@henninghall henninghall commented Aug 10, 2023

Adding support for the new architecture of Fabric and Turbo Modules.

  • iOS Fabric (iOS inline picker)
  • iOS Turbo Modules (iOS modal picker)
  • Android Fabric (Android inline picker)
  • Android Turbo Modules (Android modal picker)
  • Backward compatibility

Current backward compatibility

RN versionPlatformNew arch
enabled
Status
0.72 Android Y
N
iOS Y
N
0.71 Android Y
N
iOS Y
N
0.70 Android Y
N
iOS Y
N
0.68 Android Y
N
iOS Y
N
0.67 Android
N
iOS
N

Fixes issue #618

Test this out by using npm version react-native-date-picker@alpha

Approx hours spent: 34

Thanks to Nordic Brain Tech for partly sponsoring this work ❤️

@henninghall henninghall changed the title Support new architecture Support react native's new architecture Aug 10, 2023
@henninghall henninghall marked this pull request as ready for review September 10, 2023 10:14
@henninghall henninghall changed the title Support react native's new architecture Support React Native's new architecture Sep 10, 2023
@henninghall henninghall merged commit 2127a4d into master Sep 10, 2023
2 checks passed
@Isra1610
Copy link

Isra1610 commented Sep 11, 2023

This
return () -> {

lambda it's breaking some apps that does not have

jackOptions { enabled true }

error: lambda expressions are not supported in -source 7

@henninghall
Copy link
Owner Author

henninghall commented Sep 12, 2023

@Isra1610 thanks for making me aware of this, the lambda is replaced in version 4.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants