Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
This PR adds support for HSL colors.
I followed this documentation page to know the various syntaxes an HSL/HSLA color could have.
For HSLA, similarly to RGBA, the alpha channel is ignored.
I’ve added several test cases to check for the various syntaxes an HSL/HSLA color could have and to check that several different colors were correctly converted to HEX.
This is how it looks on Android with
fadeToColor="hsl(34, 87%, 50%)"
:I’m open to any comment you may have 🙂