-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: improved android picker + remove variants #781
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henninghall
had a problem deploying
to
e2e Android
March 18, 2024 13:26
— with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e Android
March 18, 2024 13:52
— with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e Android
March 18, 2024 14:43
— with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e Android
March 18, 2024 16:07
— with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e Android
March 19, 2024 08:11
— with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e Android
March 23, 2024 10:37
— with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e Android
March 23, 2024 10:51
— with
GitHub Actions
Failure
henninghall
had a problem deploying
to
e2e Android
March 23, 2024 11:41
— with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking
androidVariant
prop. From now on onlynativeAndroid
variant is supported,iosClone
is removed.fadeToColor
prop. No need for this sinceiosClone
variant is no longer supported.dividerHeight
prop. No need for this sinceiosClone
variant is no longer supported.textColor
prop. Usetheme
prop to make text dark or light if defaults aren't good enough. Remove because of inconsistent iOS support.Features
buttonColor
prop. Easier to use than the previously suggested method of changing Android xml config.dividerColor
prop. Easier to use than the previously suggested method of changing Android xml config.Improvements
nativeAndroid
picker. It roughly matches the previously callediosClone
's fling velocity.