Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: improved android picker + remove variants #781

Merged
merged 52 commits into from
Mar 23, 2024
Merged

Conversation

henninghall
Copy link
Owner

@henninghall henninghall commented Mar 11, 2024

Breaking

  • Removed androidVariant prop. From now on only nativeAndroid variant is supported, iosClone is removed.
  • Removed fadeToColor prop. No need for this since iosClone variant is no longer supported.
  • Removed dividerHeight prop. No need for this since iosClone variant is no longer supported.
  • Removed textColor prop. Use theme prop to make text dark or light if defaults aren't good enough. Remove because of inconsistent iOS support.

Features

  • Added buttonColor prop. Easier to use than the previously suggested method of changing Android xml config.
  • Added dividerColor prop. Easier to use than the previously suggested method of changing Android xml config.

Improvements

  • Increased fling velocity of the previously called nativeAndroid picker. It roughly matches the previously called iosClone's fling velocity.
  • Internally exposed an improved version of the core android NumberPicker component. Patched from Android source code. Enables more internal modifications of the core component than previously possible.
  • Removed dependency of maven and NumberPickerView android component.

@henninghall henninghall merged commit e5c65fc into master Mar 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant