Skip to content

Fix New Architecture support for latest React Native and Expo versions #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −0
Open

Fix New Architecture support for latest React Native and Expo versions #939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ios/RNDatePickerManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,14 @@
#import <React/RCTConvert.h>
#import <React/RCTViewManager.h>

#ifdef RCT_NEW_ARCH_ENABLED
#import "RNDatePickerSpecs.h"
#endif

@interface RNDatePickerManager : RCTViewManager
#ifdef RCT_NEW_ARCH_ENABLED
<NativeRNDatePickerSpec>
#endif

@property (strong, nonatomic) UIViewController *topViewController;

Expand Down
17 changes: 17 additions & 0 deletions ios/RNDatePickerManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,23 @@ - (double) getPickerHeight :(UIView *) alertView
return 216;
}

// New Architecture support - provide module instance to TurboModule system
+ (BOOL)requiresMainQueueSetup {
return NO;
}

#ifdef RCT_NEW_ARCH_ENABLED
// Implement the Spec protocol methods required by TurboModule
- (void)getConstants:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject {
resolve(@{});
}

- (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const facebook::react::ObjCTurboModule::InitParams &)params {
return std::make_shared<facebook::react::NativeRNDatePickerSpecJSI>(params);
}
#endif

@end



Loading