fix

henomis · May 14, 2024 · 0d2e58c · 0d2e58c
1 parent 5bfea7d
commit 0d2e58c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/embedder/huggingface/huggingface.go b/embedder/huggingface/huggingface.go
@@ -44,7 +44,10 @@ func (h *HuggingFaceEmbedder) WithModel(model string) *HuggingFaceEmbedder {
 	return h
 }
 
-func (h *HuggingFaceEmbedder) WithObserver(observer embobserver.EmbeddingObserver, traceID string) *HuggingFaceEmbedder {
+func (h *HuggingFaceEmbedder) WithObserver(
+	observer embobserver.EmbeddingObserver,
+	traceID string,
+) *HuggingFaceEmbedder {
 	h.observer = observer
 	h.observerTraceID = traceID
 	return h
@@ -65,7 +68,7 @@ func (h *HuggingFaceEmbedder) Embed(ctx context.Context, texts []string) ([]embe
 		observerEmbedding, err = embobserver.StartObserveEmbedding(
 			h.observer,
 			h.name,
-			string(h.model),
+			h.model,
 			nil,
 			h.observerTraceID,
 			observer.ContextValueParentID(ctx),

diff --git a/embedder/ollama/ollama.go b/embedder/ollama/ollama.go
@@ -56,7 +56,7 @@ func (e *Embedder) Embed(ctx context.Context, texts []string) ([]embedder.Embedd
 		observerEmbedding, err = embobserver.StartObserveEmbedding(
 			e.observer,
 			e.name,
-			string(e.model),
+			e.model,
 			nil,
 			e.observerTraceID,
 			observer.ContextValueParentID(ctx),
@@ -69,9 +69,9 @@ func (e *Embedder) Embed(ctx context.Context, texts []string) ([]embedder.Embedd
 
 	embeddings := make([]embedder.Embedding, len(texts))
 	for i, text := range texts {
-		embedding, err := e.embed(ctx, text)
-		if err != nil {
-			return nil, err
+		embedding, errEmbedd := e.embed(ctx, text)
+		if errEmbedd != nil {
+			return nil, errEmbedd
 		}
 		embeddings[i] = embedding
 	}

diff --git a/embedder/voyage/voyage.go b/embedder/voyage/voyage.go
@@ -59,7 +59,7 @@ func (e *Embedder) Embed(ctx context.Context, texts []string) ([]embedder.Embedd
 		observerEmbedding, err = embobserver.StartObserveEmbedding(
 			e.observer,
 			e.name,
-			string(e.model),
+			e.model,
 			nil,
 			e.observerTraceID,
 			observer.ContextValueParentID(ctx),