Skip "go: downloading example.com/abc/def/v1 v1.2.3" lines #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
go vet
is run prior togo test
, it may be the first time the tests are parsed and the first time certain libraries are imported.In this case,
go vet
outputs messages like this:This isn't actually a problem. The libraries are in
go.mod
andgo.sum
already, they just weren't downloaded locally.But the messages cause
go-review
to fail with:This PR skips those messages.
It is desirable to run
go vet
prior togo test
.go test
includes a subset ofgo vet
's checks internally, but its output can't be piped togo-review
, so those failures are not made visible in gerrit.I am working around this for now by running
go mod download
beforehand. But it would be nice ifgo-review
could just ignore them.