final change to ws

heracles-ec · Nov 27, 2024 · 75512fb · 75512fb
1 parent 63d34f6
commit 75512fb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/heracles/fields.py b/heracles/fields.py
@@ -557,8 +557,9 @@ async def __call__(
         wht /= wbar
 
         # bias from weights
-        musq = w2mean / wmean**2  # 1.0
-        dens = ngal / (4 * np.pi * fsky)
+        musq = 1.0
+        deff = w2mean / wmean**2
+        dens = ngal / (4 * np.pi * fsky) / deff
         bias = fsky * musq / dens
 
         # set metadata of array

diff --git a/tests/test_fields.py b/tests/test_fields.py
@@ -390,7 +390,8 @@ def test_weights(mapper, catalog):
     v1 = w.sum()
     wmean = v1 / (4.0 * npix)
     w2mean = v2 / (4.0 * npix)
-    musq = w2mean / wmean**2
+    deff = w2mean / wmean**2
+    dens = npix / np.pi / deff
 
     assert m.shape == (12 * mapper.nside**2,)
     assert m.dtype.metadata == {
@@ -402,8 +403,8 @@ def test_weights(mapper, catalog):
         "nside": mapper.nside,
         "lmax": mapper.lmax,
         "deconv": mapper.deconvolve,
-        "musq": pytest.approx(musq),
-        "dens": pytest.approx(npix / np.pi),
+        "musq": 1.0,
+        "dens": pytest.approx(dens),
         "fsky": 1.0,
         "bias": pytest.approx(bias / wbar**2),
     }