Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: remove development modules #165

Merged
merged 1 commit into from
Aug 19, 2024
Merged

MNT: remove development modules #165

merged 1 commit into from
Aug 19, 2024

Conversation

ntessore
Copy link
Contributor

@ntessore ntessore commented Aug 18, 2024 •
edited by github-actions bot
Loading

Removes the covariance and plot modules. While these are useful for development, they are not (yet?) at the level of production quality.

Closes: #156
Closes: #159
Reviewed-by: Krishna Naidoo krishna.naidoo.11@ucl.ac.uk

@ntessore
MNT: remove development modules
984854a 
Removes the `covariance` and `plot` modules.  While these are useful for
development, they are not (yet?) at the level of production quality.

Closes: #156
Closes: #159
@ntessore ntessore requested review from ucapbba and knaidoo29 August 18, 2024 22:12
knaidoo29
knaidoo29 approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@knaidoo29 knaidoo29 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine and nothing appears to be dependent on these modules, so this looks fairly well contained.

@ntessore ntessore merged commit ea2d5c2 into main Aug 19, 2024
9 checks passed
@ntessore ntessore deleted the nt/cleanup branch August 19, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knaidoo29 knaidoo29 knaidoo29 approved these changes

@ucapbba ucapbba Awaiting requested review from ucapbba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove plot module Remove old kmeans code for jackknife
2 participants
@ntessore @knaidoo29