Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API(fields): rename weight functions to masks #99

Merged
merged 1 commit into from
Jan 5, 2024
Merged

API(fields): rename weight functions to masks #99

merged 1 commit into from
Jan 5, 2024

Conversation

ntessore
Copy link
Contributor

@ntessore ntessore commented Jan 5, 2024

Use "mask" instead of "weight" as the field property that designates the weight function. This makes it less ambiguous wrt. the weights from a catalogue.

Closes: #98

@ntessore ntessore merged commit 41cde36 into main Jan 5, 2024
6 checks passed
@ntessore ntessore deleted the pr-98 branch January 5, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The use of "weight" is ambiguous
1 participant