Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lazy-require in the simplify code #399

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Conversation

pavpanchekha
Copy link
Contributor

@pavpanchekha pavpanchekha commented Aug 3, 2021

This PR removes the dynamic-require calls in simplify.rkt and replaces them with lazy-require. I've tested and this seems to work with both regraph and egg-herbie, and if egg-herbie is missing it only loads and runs regraph.

Another benefit of this is it declares the dependency somehow to Racket, whereas dynamic-require doesn't. I'm not sure what this actually does for us but it's probably good.

@pavpanchekha pavpanchekha requested a review from oflatt August 3, 2021 22:29
@oflatt
Copy link
Collaborator

oflatt commented Aug 6, 2021

This is good, I tested it out and it works great! It makes it much cleaner.

@pavpanchekha pavpanchekha merged commit 6bcff2b into master Aug 6, 2021
@pavpanchekha pavpanchekha deleted the simplify-simplify branch August 6, 2021 22:27
@pavpanchekha pavpanchekha restored the simplify-simplify branch January 18, 2025 23:53
@pavpanchekha pavpanchekha deleted the simplify-simplify branch January 18, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants