-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(env): parse env=KEY=VALUE for env vars #1394
Conversation
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
9fe7aa9
to
7187617
Compare
}) | ||
} | ||
|
||
pub fn fdt_args() -> Option<&'static str> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like brief doc comments on functions, but this is a personal preference.
Shouldn't these functions be pub (crate)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these functions be
pub (crate)
?
I prefer not setting the export scope when the whole module is private.
|
||
dtb.get_property("/chosen", "bootargs") | ||
.map(|property| str::from_utf8(property).unwrap()) | ||
None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't we throw out these functions while we are on it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do away with these architecture-specific bootargs once we have migrated all platforms to FDT bootargs and do the bootinfo version jump. We still have the bootargs in the bootinfo for x86-64 QEMU and Linux boot.
LGTM
Sounds reasonable.
I think this is a must. It is exotic, but would lead to some strange bugs if there is just some environment that uses it.
Just throw them out. On my V2 of the uhyve interface, these are also not present anymore. I doubt that uhyve is used "in production" right now. |
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
4c81e6b
to
a5f952b
Compare
I have implemented support for
👍 |
This PR
env=KEY=VALUE
kernel arguments for environment variable initialization, andCMDSIZE
andCMDVAL
hypercalls to use the kernel-maintained environment on Uhyve (breaking).Questions
env=KEY=VALUE
format? This differs from our current format for other kernel arguments, such as-freq FREQ
and-ip IP
. I think we should migrate those tofreq=FREQ
andip=IP
eventually.=
in environment variable names?Extracted 0. commit: #1396
Corresponding Uhyve PR: hermit-os/uhyve#758