Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a recursive mutex isn't part of the hermit-abi #825

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

stlankes
Copy link
Contributor

@stlankes stlankes commented Aug 7, 2023

No description provided.

@stlankes stlankes requested a review from mkroening August 7, 2023 13:11
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pthread-embedded uses this: https://github.com/hermitcore/pthread-embedded/blob/bcafd6f5102bf8cc600793620f58c63317af6d85/platform/hermit/pte_osal.c#L115-L116

Rust does not, though, so we can make this #[cfg(feature = "newlib"]) instead.

@stlankes
Copy link
Contributor Author

stlankes commented Aug 7, 2023

Ah, I fixed it.

@mkroening mkroening added this pull request to the merge queue Aug 9, 2023
Merged via the queue into hermit-os:master with commit e1a0707 Aug 9, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants