Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Hypercall interface in distinct crate #452

Merged
merged 21 commits into from
Jun 2, 2023
Merged

Move Hypercall interface in distinct crate #452

merged 21 commits into from
Jun 2, 2023

Conversation

jounathaen
Copy link
Member

@jounathaen jounathaen commented Jan 4, 2023

This should enhance readability and allows reusing code in libhermit. Currently, the hypercall interface there is just copy-pasted.

Open points:

  • Throw out the constants.
  • Remove unused NETREAD|NETSTAT|NETWRITE hypercalls.
  • Introduce a version checking mechanism.
  • Use a common cargo workspace with uhyve
  • Ensure stable compilation
  • Think about a way to make this compatible with non-portIO architectures (aka: not x86 architectures) (related: add AARCH64 support on Linux #324 add AARCH64 support on macOS  #325 )
  • Generalize this from Hypercall Interface to Uhyve-Interface and accommodate things like UART_PORT as well.
  • Enhance the naming of the parameters.

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #452 (dc7da20) into master (a696cb1) will decrease coverage by 0.57%.
The diff coverage is 46.40%.

@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
- Coverage   64.04%   63.47%   -0.57%     
==========================================
  Files          16       18       +2     
  Lines        2197     2204       +7     
==========================================
- Hits         1407     1399       -8     
- Misses        790      805      +15     
Impacted Files Coverage Δ
uhyve-interface/src/parameters.rs 0.00% <0.00%> (ø)
uhyve-interface/src/lib.rs 5.55% <5.55%> (ø)
src/linux/vcpu.rs 71.73% <44.00%> (+1.35%) ⬆️
src/vm.rs 76.08% <72.91%> (-0.77%) ⬇️

@jounathaen jounathaen force-pushed the uhypercall branch 7 times, most recently from d488734 to 82c4a1b Compare January 6, 2023 12:43
@jounathaen jounathaen marked this pull request as ready for review January 6, 2023 12:43
@jounathaen jounathaen force-pushed the uhypercall branch 10 times, most recently from c02a699 to 47e0285 Compare January 6, 2023 14:28
@jounathaen jounathaen changed the title [Draft] Move Hypercall interface in distinct crate Move Hypercall interface in distinct crate Jan 6, 2023
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative. 👍

Are clippy and doc CI run automatically for this workspace member?

Could you squash a few commits together?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
uhyve-interface/Cargo.toml Outdated Show resolved Hide resolved
uhyve-interface/Cargo.toml Outdated Show resolved Hide resolved
uhyve-interface/.gitignore Show resolved Hide resolved
uhyve-interface/Cargo.toml Show resolved Hide resolved
uhyve-interface/src/parameters.rs Outdated Show resolved Hide resolved
uhyve-interface/src/parameters.rs Outdated Show resolved Hide resolved
uhyve-interface/src/parameters.rs Outdated Show resolved Hide resolved
uhyve-interface/src/parameters.rs Outdated Show resolved Hide resolved
uhyve-interface/src/parameters.rs Outdated Show resolved Hide resolved
@jounathaen
Copy link
Member Author

Thank you for your nice and extensive review! I'll implement the changes, hopefully next week. :-)

@jounathaen jounathaen force-pushed the uhypercall branch 4 times, most recently from 5adf7fb to d807c98 Compare June 2, 2023 09:13
@jounathaen jounathaen added this pull request to the merge queue Jun 2, 2023
Merged via the queue into master with commit bc902db Jun 2, 2023
@mkroening mkroening deleted the uhypercall branch June 2, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants