Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Enable RUST_BACKTRACE for tests #723

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

n0toose
Copy link
Member

@n0toose n0toose commented Jul 3, 2024

Could be useful in some cases when GitHub Actions fails on a specific target.

@n0toose
Copy link
Member Author

n0toose commented Jul 3, 2024

I went through with issuing a PR for this because I think I missed it in: #701 (comment)

Having the backtrace in the logs in the first place would be optimal - provided that I don't make an identical commit in my own tree just to be able to read the backtrace and then undo it - or by using a system that I can SSH onto.

(Note: This was a quick change and I did not test it against the sysinfo PR or otherwise)

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.17%. Comparing base (e9fc8de) to head (e8340ed).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #723   +/-   ##
=======================================
  Coverage   68.17%   68.17%           
=======================================
  Files          20       20           
  Lines        2319     2319           
=======================================
  Hits         1581     1581           
  Misses        738      738           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Could be useful in some cases when GitHub Actions fails on a specific
target.
@n0toose
Copy link
Member Author

n0toose commented Jul 3, 2024

Replaced full with 1, because that's what the Rust toolchain instructs you to do - I imagined it might be more direct than full.

It's also what rust-lang/rust does: https://github.com/rust-lang/rust/actions/runs/5192558478/workflow

@mkroening mkroening added this pull request to the merge queue Jul 8, 2024
Merged via the queue into hermit-os:main with commit 983f1e8 Jul 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants