Add missing runtime libs to heroku-22 and heroku-24 #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- libgeoip1 because of libgeoip-dev - libhashkit2 because of libhashkit-dev - libmemcachedutil2 because of libmemcached-dev - libnetpbm10 because of libnetpbm10-dev - libwmf-0.2-7 because of libwmf-dev GUS-W-16381871
dzuelke
force-pushed
the
add-missing-runtime-libs
branch
from
89e438f to
6d28afc
Compare
|
Sizes: % docker run -u root --rm -ti heroku/heroku:22 bash
root@2e3c355b3af4:/# apt-get update
…
root@2e3c355b3af4:/# apt-get install libgeoip1 libhashkit2 libmemcachedutil2 libnetpbm10 libwmf-0.2-7
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Suggested packages:
geoip-bin libwmf-0.2-7-gtk
The following NEW packages will be installed:
libgeoip1 libhashkit2 libmemcachedutil2 libnetpbm10 libwmf-0.2-7
0 upgraded, 5 newly installed, 0 to remove and 3 not upgraded.
Need to get 284 kB of archives.
After this operation, 1001 kB of additional disk space will be used.
…% docker run -u root --rm -ti heroku/heroku:24 bash
root@5e5722257542:/# apt-get update
…
root@5e5722257542:/# apt-get install libgirepository-1.0-1 libidn12 libmemcachedutil2t64 libwebpdecoder3 libwmf-0.2-7
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Suggested packages:
libwmf-0.2-7-gtk
The following NEW packages will be installed:
libgirepository-1.0-1 libidn12 libmemcachedutil2t64 libwebpdecoder3
libwmf-0.2-7
0 upgraded, 5 newly installed, 0 to remove and 2 not upgraded.
Need to get 328 kB of archives.
After this operation, 1278 kB of additional disk space will be used.
… |
dzuelke
force-pushed
the
add-missing-runtime-libs
branch
3 times, most recently
from
8f0b18b to
08092e3
Compare
- libgirepository-1.0-1 because of libgirepository1.0-dev and libgirepository-1.0-dev - libidn12 because of libidn-dev - libmemcachedutil2t64 because of libmemcached-dev - libwebpdecoder3 because of libwebp-dev - libwmf-0.2-7 because of libwmf-dev GUS-W-16381871
dzuelke
force-pushed
the
add-missing-runtime-libs
branch
from
08092e3 to
f733e36
Compare
edmorley
reviewed
Sep 6, 2024
|
@dzuelke Could you update the PR description so it matches the final version of the PR? :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a general rule, we make dynamic libraries available in the run base images if the packages containing headers for dynamic linking (typically named
lib…-dev) are present in the build image.This ensures that programs that dynamically link against libraries using these headers at build time (e.g. native extensions for various languages) work reliably at runtime.
A recent review of the list of packages on all stacks turned up a number of packages that aren't available at runtime, but have build time headers.
Ignoring
heroku-20(as it is deprecated), and disregardinglibpcre…libraries for character strings other than UTF-8 (which already are in the run images) as well as X11-related libraries, we're missing the following:heroku-22:libgeoip1because oflibgeoip-devlibhashkit2because oflibhashkit-devlibmemcachedutil2because oflibmemcached-devlibnetpbm10because oflibnetpbm10-devlibwmf-0.2-7because oflibwmf-devheroku-24:libgirepository-1.0-1because oflibgirepository1.0-devandlibgirepository-1.0-devlibidn12because oflibidn-devlibmemcachedutil2t64because oflibmemcached-devlibwebpdecoder3because oflibwebp-devlibwmf-0.2-7because oflibwmf-devGUS-W-16381871