fix: remove '-tags heroku' passed to CLI to honor '-tags' in GOFLAGS #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwlewis
requested changes
Feb 27, 2025
There was a problem hiding this comment.
There's a long history of apps on Heroku that depend on the -tags heroku for conditional compilation. Removing this would break a bunch of apps, so I can't accept this as-is. Maybe the buildpack could set a default value of GOFLAGS=-tags heroku when GOFLAGS was empty or unset instead?
|
Makes sense. I'm not using this anymore so I will leave it at that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI flag
-tags herokuforcefully set in the buildpack overrides the tags set in the GOFLAGS environment variable, as per specified in:https://github.com/golang/go/blob/c96939fbed3d60159dc81ee9ad591de8cfd41168/src/cmd/go/internal/help/helpdoc.go#L525-L531
However, it makes it impossible to set other tags such as
viper_bind_struct(see spf13/viper#1720) using the standardGOFLAGS="-tags=viper_bind_struct".