PHP 8.4 compatibility for Composer platform package installer plugin

We currently perform the install using a bootstrapped minimal 8.3, but it doesn't hurt to be ready.
heroku · Dec 17, 2024 · 1438056 · 1438056
1 parent 110dc1b
commit 1438056
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/support/installer/composer.json b/support/installer/composer.json
@@ -1,7 +1,7 @@
 {
 	"type": "composer-plugin",
 	"name": "heroku/installer-plugin",
-	"version": "1.7.1",
+	"version": "1.7.2",
 	"autoload": {
 		"psr-4": {
 			"Heroku\\Buildpack\\PHP\\": "src/"
@@ -13,6 +13,7 @@
 		"plugin-modifies-install-path": true
 	},
 	"require": {
-		"composer-plugin-api": "^2.3.0"
+		"composer-plugin-api": "^2.3.0",
+		"php": ">=7.1"
 	}
 }
diff --git a/support/installer/src/NoopDownloader.php b/support/installer/src/NoopDownloader.php
@@ -24,12 +24,12 @@ public function getInstallationSource(): string
 		return "dist";
 	}
 
-	public function download(PackageInterface $package, string $path, PackageInterface $prevPackage = null): PromiseInterface
+	public function download(PackageInterface $package, string $path, ?PackageInterface $prevPackage = null): PromiseInterface
 	{
 		return \React\Promise\resolve(null);
 	}
 
-	public function prepare(string $type, PackageInterface $package, string $path, PackageInterface $prevPackage = null): PromiseInterface
+	public function prepare(string $type, PackageInterface $package, string $path, ?PackageInterface $prevPackage = null): PromiseInterface
 	{
 		return \React\Promise\resolve(null);
 	}
@@ -50,7 +50,7 @@ public function remove(PackageInterface $package, string $path): PromiseInterfac
 		return \React\Promise\resolve(null);
 	}
 
-	public function cleanup(string $type, PackageInterface $package, string $path, PackageInterface $prevPackage = null): PromiseInterface
+	public function cleanup(string $type, PackageInterface $package, string $path, ?PackageInterface $prevPackage = null): PromiseInterface
 	{
 		return \React\Promise\resolve(null);
 	}