Fix failing deployment caused by version error s3contents #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed non existing version number
mordieross
approved these changes
Feb 14, 2019
|
Not sure why this says i’ve Apparently Approved this as I never and am not able to do that anyway. |
|
But would like the version corrected so the button works again if any real approver can take look. Thanks |
|
@kenneth-reitz could you take a look at my PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got an installation error when I tried to deploy on Heroku. It was caused by a wrong version of a package in the pip.lock file.
s3contents was referring to version 0.2.2, which does not exist. Changed it to latest version 0.1.12 and updated all other packages as well. It now deploys as expected.
This PR does not fix the password not being recognised.