Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progress): add RTL support to the progress component (#4908) #4911

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

waleed-mobasher
Copy link

@waleed-mobasher waleed-mobasher commented Feb 23, 2025

Closes #4908

📝 Description

Add RTL support to the Progress component.

⛳️ Current behavior (updates)

The Progress component currently lacks support for right-to-left (RTL) direction, when the page direction is RTL the progress bar is filled from left-to-right as it behaves in LTR pages.

🚀 New behavior

Now the progress bar is filled from right-to-left if the page direction is RTL.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Summary by CodeRabbit

Summary by CodeRabbit

  • Style
    • Enhanced the progress component’s appearance to correctly support both right-to-left and left-to-right layouts, ensuring smooth and directionally accurate animations for a consistent user experience.
    • Added new classes for improved responsiveness in RTL layouts, including rotation and transform origin adjustments.

Copy link

changeset-bot bot commented Feb 23, 2025

⚠️ No Changeset found

Latest commit: 97032af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 23, 2025

@waleed-mobasher is attempting to deploy a commit to the HeroUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Feb 23, 2025

Walkthrough

This pull request updates the CSS class definitions in the progress component to enhance right-to-left (RTL) support. The changes modify the track slot to include a rotation class for RTL layouts and adjust the indicator slot by adding directional origin classes for both RTL and left-to-right (LTR) contexts. The indeterminate state for the indicator is also updated to use these new classes. No changes were made to exported or public declarations.

Changes

File Change Summary
packages/core/theme/src/components/progress.ts Updated CSS for RTL support: Added rtl:rotate-180 to the track slot, and replaced origin-left with rtl:origin-right and ltr:origin-left on the indicator slot, including updates for the isIndeterminate variant.

Suggested reviewers

  • jrgarciadev

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 97032af and a299801.

📒 Files selected for processing (1)
  • .changeset/happy-kangaroos-thank.md (1 hunks)
🔇 Additional comments (4)
.changeset/happy-kangaroos-thank.md (4)

1-3: Review of Changeset Header Format
The header correctly labels the update for the @heroui/progress package as a patch. The use of YAML front matter (delimited by ---) is appropriate and clearly sets the context for the update.


5-6: Clarity in Describing the RTL Enhancement
The explanatory text succinctly outlines the objective of the update—ensuring that the progress bar works correctly for both LTR and RTL layouts. This narrative helps reviewers and future maintainers understand the purpose behind the change.


7-9: Detailing the Track Class Update
The note under "In the track class:" clearly explains the addition of the rtl:rotate-180 class. This explanation makes it easy to see how the track will behave in RTL mode—by rotating 180 degrees.


10-12: Explanation of Indicator Class Modifications
The description provided for the indicator class improvements is clear and informative. It details the addition of rtl:origin-right and ltr:origin-left which adjust the transform origin for correct animation direction based on the text layout. This aligns well with the PR objective of adding RTL support.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Lack of RTL Support in Progress
1 participant