Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breadcrumb): broken start & end content #4922

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

wingkwong
Copy link
Member

@wingkwong wingkwong commented Feb 24, 2025

Closes #4921

📝 Description

⛳️ Current behavior (updates)

image

image

🚀 New behavior

image

image

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

  • Bug Fixes

    • Resolved an issue causing broken breadcrumb content display.
  • Style

    • Updated breadcrumb appearance by allowing text to span multiple lines instead of being restricted to a single line.

Copy link

linear bot commented Feb 24, 2025

@wingkwong wingkwong added this to the v2.7.3 milestone Feb 24, 2025
Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
heroui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 3:14pm
heroui-sb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 3:14pm

Copy link
Contributor

coderabbitai bot commented Feb 24, 2025

Walkthrough

This pull request documents a patch for the "@heroui/theme" package. A changeset entry has been added to record a fix for an issue with broken breadcrumb content (issue #4921). In addition, the "line-clamp-1" CSS class has been removed from the breadcrumb item component in the theme package, modifying the styling so that breadcrumb text is no longer forcibly truncated to one line. No changes were made to exported or public entity declarations.

Changes

File Summary
.changeset/metal-chicken-happen.md Added a changeset entry documenting a patch for "@heroui/theme" to fix broken start and end content in breadcrumbs (#4921).
packages/.../breadcrumbs.ts Removed the "line-clamp-1" class from the breadcrumb item's slot, altering the text display from single-line to multi-line.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 29df4f5 and 9e63ebb.

📒 Files selected for processing (2)
  • .changeset/metal-chicken-happen.md (1 hunks)
  • packages/core/theme/src/components/breadcrumbs.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/core/theme/src/components/breadcrumbs.ts
✅ Files skipped from review due to trivial changes (1)
  • .changeset/metal-chicken-happen.md
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: TypeScript
  • GitHub Check: Continuous Release
  • GitHub Check: Build
  • GitHub Check: ESLint

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pkg-pr-new bot commented Feb 24, 2025

Open in Stackblitz

@heroui/accordion

npm i https://pkg.pr.new/@heroui/accordion@4922

@heroui/alert

npm i https://pkg.pr.new/@heroui/alert@4922

@heroui/autocomplete

npm i https://pkg.pr.new/@heroui/autocomplete@4922

@heroui/avatar

npm i https://pkg.pr.new/@heroui/avatar@4922

@heroui/badge

npm i https://pkg.pr.new/@heroui/badge@4922

@heroui/breadcrumbs

npm i https://pkg.pr.new/@heroui/breadcrumbs@4922

@heroui/button

npm i https://pkg.pr.new/@heroui/button@4922

@heroui/calendar

npm i https://pkg.pr.new/@heroui/calendar@4922

@heroui/card

npm i https://pkg.pr.new/@heroui/card@4922

@heroui/checkbox

npm i https://pkg.pr.new/@heroui/checkbox@4922

@heroui/chip

npm i https://pkg.pr.new/@heroui/chip@4922

@heroui/code

npm i https://pkg.pr.new/@heroui/code@4922

@heroui/date-input

npm i https://pkg.pr.new/@heroui/date-input@4922

@heroui/date-picker

npm i https://pkg.pr.new/@heroui/date-picker@4922

@heroui/divider

npm i https://pkg.pr.new/@heroui/divider@4922

@heroui/drawer

npm i https://pkg.pr.new/@heroui/drawer@4922

@heroui/dropdown

npm i https://pkg.pr.new/@heroui/dropdown@4922

@heroui/form

npm i https://pkg.pr.new/@heroui/form@4922

@heroui/image

npm i https://pkg.pr.new/@heroui/image@4922

@heroui/input

npm i https://pkg.pr.new/@heroui/input@4922

@heroui/input-otp

npm i https://pkg.pr.new/@heroui/input-otp@4922

@heroui/kbd

npm i https://pkg.pr.new/@heroui/kbd@4922

@heroui/link

npm i https://pkg.pr.new/@heroui/link@4922

@heroui/listbox

npm i https://pkg.pr.new/@heroui/listbox@4922

@heroui/menu

npm i https://pkg.pr.new/@heroui/menu@4922

@heroui/modal

npm i https://pkg.pr.new/@heroui/modal@4922

@heroui/navbar

npm i https://pkg.pr.new/@heroui/navbar@4922

@heroui/number-input

npm i https://pkg.pr.new/@heroui/number-input@4922

@heroui/pagination

npm i https://pkg.pr.new/@heroui/pagination@4922

@heroui/popover

npm i https://pkg.pr.new/@heroui/popover@4922

@heroui/progress

npm i https://pkg.pr.new/@heroui/progress@4922

@heroui/radio

npm i https://pkg.pr.new/@heroui/radio@4922

@heroui/ripple

npm i https://pkg.pr.new/@heroui/ripple@4922

@heroui/scroll-shadow

npm i https://pkg.pr.new/@heroui/scroll-shadow@4922

@heroui/select

npm i https://pkg.pr.new/@heroui/select@4922

@heroui/skeleton

npm i https://pkg.pr.new/@heroui/skeleton@4922

@heroui/slider

npm i https://pkg.pr.new/@heroui/slider@4922

@heroui/snippet

npm i https://pkg.pr.new/@heroui/snippet@4922

@heroui/spacer

npm i https://pkg.pr.new/@heroui/spacer@4922

@heroui/spinner

npm i https://pkg.pr.new/@heroui/spinner@4922

@heroui/switch

npm i https://pkg.pr.new/@heroui/switch@4922

@heroui/table

npm i https://pkg.pr.new/@heroui/table@4922

@heroui/tabs

npm i https://pkg.pr.new/@heroui/tabs@4922

@heroui/toast

npm i https://pkg.pr.new/@heroui/toast@4922

@heroui/tooltip

npm i https://pkg.pr.new/@heroui/tooltip@4922

@heroui/user

npm i https://pkg.pr.new/@heroui/user@4922

@heroui/react

npm i https://pkg.pr.new/@heroui/react@4922

@heroui/system

npm i https://pkg.pr.new/@heroui/system@4922

@heroui/system-rsc

npm i https://pkg.pr.new/@heroui/system-rsc@4922

@heroui/theme

npm i https://pkg.pr.new/@heroui/theme@4922

@heroui/use-aria-accordion

npm i https://pkg.pr.new/@heroui/use-aria-accordion@4922

@heroui/use-aria-accordion-item

npm i https://pkg.pr.new/@heroui/use-aria-accordion-item@4922

@heroui/use-aria-button

npm i https://pkg.pr.new/@heroui/use-aria-button@4922

@heroui/use-aria-link

npm i https://pkg.pr.new/@heroui/use-aria-link@4922

@heroui/use-aria-modal-overlay

npm i https://pkg.pr.new/@heroui/use-aria-modal-overlay@4922

@heroui/use-aria-multiselect

npm i https://pkg.pr.new/@heroui/use-aria-multiselect@4922

@heroui/use-callback-ref

npm i https://pkg.pr.new/@heroui/use-callback-ref@4922

@heroui/use-clipboard

npm i https://pkg.pr.new/@heroui/use-clipboard@4922

@heroui/use-data-scroll-overflow

npm i https://pkg.pr.new/@heroui/use-data-scroll-overflow@4922

@heroui/use-disclosure

npm i https://pkg.pr.new/@heroui/use-disclosure@4922

@heroui/use-draggable

npm i https://pkg.pr.new/@heroui/use-draggable@4922

@heroui/use-image

npm i https://pkg.pr.new/@heroui/use-image@4922

@heroui/use-infinite-scroll

npm i https://pkg.pr.new/@heroui/use-infinite-scroll@4922

@heroui/use-intersection-observer

npm i https://pkg.pr.new/@heroui/use-intersection-observer@4922

@heroui/use-is-mobile

npm i https://pkg.pr.new/@heroui/use-is-mobile@4922

@heroui/use-is-mounted

npm i https://pkg.pr.new/@heroui/use-is-mounted@4922

@heroui/use-measure

npm i https://pkg.pr.new/@heroui/use-measure@4922

@heroui/use-pagination

npm i https://pkg.pr.new/@heroui/use-pagination@4922

@heroui/use-real-shape

npm i https://pkg.pr.new/@heroui/use-real-shape@4922

@heroui/use-ref-state

npm i https://pkg.pr.new/@heroui/use-ref-state@4922

@heroui/use-resize

npm i https://pkg.pr.new/@heroui/use-resize@4922

@heroui/use-safe-layout-effect

npm i https://pkg.pr.new/@heroui/use-safe-layout-effect@4922

@heroui/use-scroll-position

npm i https://pkg.pr.new/@heroui/use-scroll-position@4922

@heroui/use-ssr

npm i https://pkg.pr.new/@heroui/use-ssr@4922

@heroui/use-theme

npm i https://pkg.pr.new/@heroui/use-theme@4922

@heroui/use-update-effect

npm i https://pkg.pr.new/@heroui/use-update-effect@4922

@heroui/aria-utils

npm i https://pkg.pr.new/@heroui/aria-utils@4922

@heroui/dom-animation

npm i https://pkg.pr.new/@heroui/dom-animation@4922

@heroui/framer-utils

npm i https://pkg.pr.new/@heroui/framer-utils@4922

@heroui/react-rsc-utils

npm i https://pkg.pr.new/@heroui/react-rsc-utils@4922

@heroui/react-utils

npm i https://pkg.pr.new/@heroui/react-utils@4922

@heroui/shared-icons

npm i https://pkg.pr.new/@heroui/shared-icons@4922

@heroui/shared-utils

npm i https://pkg.pr.new/@heroui/shared-utils@4922

@heroui/stories-utils

npm i https://pkg.pr.new/@heroui/stories-utils@4922

@heroui/test-utils

npm i https://pkg.pr.new/@heroui/test-utils@4922

commit: 9e63ebb

@jrgarciadev jrgarciadev merged commit 2774a1b into canary Feb 26, 2025
10 checks passed
@jrgarciadev jrgarciadev deleted the fix/eng-2155 branch February 26, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - broken start & end content in breadcrumb
2 participants