test: add ISO e2e tests #953
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
==========================================
+ Coverage 69.76% 69.83% +0.06%
==========================================
Files 245 245
Lines 10711 10711
==========================================
+ Hits 7473 7480 +7
+ Misses 2562 2555 -7
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jooola
reviewed
Jan 10, 2025
| t.Run("json", func(t *testing.T) { | ||
| out, err := runCommand(t, "iso", "list", "-o=json") | ||
| require.NoError(t, err) | ||
| assert.True(t, json.Valid([]byte(out)), "is valid JSON") |
There was a problem hiding this comment.
This isn't testing much, should we try to check the data inside?
jooola
reviewed
Jan 10, 2025
| }) | ||
| }) | ||
|
|
||
| t.Run("describe", func(t *testing.T) { |
There was a problem hiding this comment.
There is no json output for describe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.