refactor: use generic request for actions calls #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #624 +/- ##
==========================================
+ Coverage 71.98% 77.33% +5.34%
==========================================
Files 49 49
Lines 4348 3971 -377
==========================================
- Hits 3130 3071 -59
+ Misses 909 685 -224
+ Partials 309 215 -94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apricote
approved these changes
Mar 18, 2025
|
|
||
| var respBody PrimaryIPAssignResult | ||
| resp, err := c.client.Do(req, &respBody) | ||
| respBody, resp, err := postRequest[PrimaryIPAssignResult](ctx, c.client, reqPath, nil) |
There was a problem hiding this comment.
This uses a PrimaryIPAssignResult but its the Unassign call.
jooola
added a commit
that referenced
this pull request
Mar 19, 2025
This does not include the fixes for the primary ip client, because those changes are more involved. Related to the comments in #624
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.