Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug that post.permalink error when config.relative_link is true #2760

Merged
merged 2 commits into from
Dec 4, 2017
Merged

fix a bug that post.permalink error when config.relative_link is true #2760

merged 2 commits into from
Dec 4, 2017

Conversation

tcatche
Copy link
Contributor

@tcatche tcatche commented Sep 19, 2017

When set relative_link to true in config.yml, the post.permalink will incrrect.

For example:
When config.url is http://yoursite.com/ and the post's path is 2017/09/a-post ,the result will http://yoursite.com2017/09/a-post . It misses a separator / after the site url.

This pull request aims to repair this problem.

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Sep 19, 2017

Coverage Status

Coverage increased (+0.0007%) to 97.165% when pulling c2437d8 on tcatche:master into 9ad6c47 on hexojs:master.

@coveralls
Copy link

coveralls commented Sep 19, 2017

Coverage Status

Coverage increased (+0.0007%) to 97.165% when pulling 6156391 on tcatche:master into 9ad6c47 on hexojs:master.

Copy link
Member

@NoahDragon NoahDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@NoahDragon
Copy link
Member

I will keep the PR unmerged, hope someone uses relative_url can give it a try.

@JLHwung
Copy link
Collaborator

JLHwung commented Dec 4, 2017

Thank you so much for you contribution. Hexo can't be rock without contributors like you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants