Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the context is getting canceled immediately after making a request, due to defering the
cancel()
within a helper function. The symptom was that all cached files are truncated to a few KB.Mirrors should delete truncated cached files after upgrading wrench.
As a follow up, we should also write the response to a temporary file and atomically swap it with the destination afterward. Even with this fix, it is possible to cache a truncated file at a served path when the connection to ziglang.org is dropped.