Bring together changes from downstream forks. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seeing ``KeyError`` when copy&pasting in terminal directly from the source (docstring) is bad experience ;-)
Update termcolor.py
If stdout is not a tty (e.g. a file), a user does not normally want to have ANSI escape codes present in the output. This commit adds a check (sys.stdout.isatty()) to verify if stdout is a tty so it will only output color codes in this specific case.
Merging in changes by hbuschme.
gunchev
added a commit
to gunchev/termcolor_dg
that referenced
this pull request
Feb 8, 2022
Both check and cross marks were rendered white in a green box, making it hard to distinguish. Changin the unicode character from '❎' to '❌' should hopefully fix it. Fixes dngunchev/termcolor2#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request represents several changes that I gathered up from downstream forks.
While I did a little work coaxing merges, the bulk of these changes represent work done by @lukaszb @edmund-huber @hbuschme and @iulian3144 at various points over the last 7 years.
This request incorporates the changes made in Pull request #2, it does not incorporate #3, which I found didn't matter (for me on Debian Linux, python 3.7.3). It also didn't break when I applied the change, and it should merge cleanly with my branch.
This pull includes things like support for 256 colors, among other fixes.