Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banish hh ignore error from codegen #544

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

lexidor
Copy link
Contributor

@lexidor lexidor commented May 24, 2023

Fixes:

  • No more HH_IGNORE_ERROR directives in codegen.
  • No more HH_IGNORE_ERROR directives in hand rolled nodes.
  • Various HH_IGNORE_ERROR -> HH\FIXME\UNSAFE_CAST<Ta, Tb>(...) migrations.
    • It is not that I particularly like UNSAFE_CAST, but they are better than a 4110 fixme, right?
  • Remove HH_IGNORE_ERROR from declarations.

Codegen changes in the next commit.
These aren't affected by the codegen changes.
These are particularly likely to cause non-local bugs (in general).
By removing the `final` modifier, and sealing it empty, we can remove this directive.
This functionality can be implemented with a well-typed Hack API now, yippee!
@lexidor lexidor force-pushed the banish-hh-ignore-error-from-codegen branch from a5901d4 to 680174a Compare December 24, 2023 13:17
@lexidor
Copy link
Contributor Author

lexidor commented Dec 24, 2023

CI doesn't run here anymore, so you'll have to look at the CI of my clone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants